Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename editor preference section heading #7437

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Rename editor preference section heading #7437

merged 1 commit into from
Jan 4, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Jan 4, 2022

Description

Re-opening #7428 because the build failed due to the long branch name, see #7428 (comment).

This will update the IDE (Editor) preference section heading from Default IDE to Editor.

This can probably be further improved in #6602.

See relevant discussion (internal).

How to test

Go to /preferences.

Release Notes

Rename editor preference section heading

@roboquat roboquat added release-note team: IDE team: webapp Issue belongs to the WebApp team labels Jan 4, 2022
@gtsiolis gtsiolis requested a review from jeanp413 January 4, 2022 13:36
@roboquat roboquat added the size/S label Jan 4, 2022
@gtsiolis gtsiolis mentioned this pull request Jan 4, 2022
Closed
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jan 4, 2022 •
edited
Loading

@jeanp413 could you take another pass? Build will most probably pass now.

Cc @akosyakov @loujaybee in case this it'd be better to close this for now. 📕

@gtsiolis gtsiolis closed this Jan 4, 2022
@gtsiolis gtsiolis reopened this Jan 4, 2022
@JanKoehnlein
Copy link
Contributor

/approve

jeanp413
jeanp413 approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@jeanp413 jeanp413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@roboquat roboquat added the lgtm label Jan 4, 2022
@roboquat
Copy link
Contributor

roboquat commented Jan 4, 2022

LGTM label has been added.

Git tree hash: 71bd566a0d4856d023b5a74447dc3a7647b75263

@roboquat
Copy link
Contributor

roboquat commented Jan 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein, jeanp413

Associated issue: #6602

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 9b0eebd into main Jan 4, 2022
@roboquat roboquat deleted the gt/rename-editor-section branch January 4, 2022 16:16
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jan 4, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Thanks @JanKoehnlein @jeanp413! 🧡

@gtsiolis gtsiolis requested review from JanKoehnlein and removed request for JanKoehnlein January 4, 2022 16:16
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanp413 jeanp413 jeanp413 approved these changes

Assignees

@jeanp413 jeanp413

Labels
approved deployed: webapp Meta team change is running in production release-note size/S team: IDE team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gtsiolis @JanKoehnlein @roboquat @jeanp413