Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve review process for Team Workspace API Components #8981

Closed
kylos101 opened this issue Mar 28, 2022 · 3 comments · Fixed by #9092
Closed

Improve review process for Team Workspace API Components #8981

kylos101 opened this issue Mar 28, 2022 · 3 comments · Fixed by #9092
Assignees
Labels
team: workspace Issue belongs to the Workspace team

Comments

@kylos101
Copy link
Contributor

kylos101 commented Mar 28, 2022

Is your feature request related to a problem? Please describe

A few folders for Workspace components require approval from explicit individuals. [1][2][3]

This can create bottlenecks for the team. As an experiment, we'd like to try using lazy consensus.

Describe the behaviour you'd like

With great power comes great responsibility. 🕷️ 👨

For the Team Workspace components mentioned above (APIs):

  1. Replace @csweichel and @aledbf for 3 workspace APIs with @gitpod-io/engineering-workspace .
  2. When teammates add approval for a PR containing API changes, the approval message must contain two things:
    *. /LGTM
    *. /hold for 28 hours as lazy consensus <-- to allow time for the team to consider the PR as a whole.

Describe alternatives you've considered

Leave @aledbf as approver for the three components, but, replace approval from @csweichel with :

  1. ws-daemon-api -> @Furisto
  2. ws-manager-api -> @sagor999

Additional context

Ref: Slack

@kylos101 kylos101 added the team: workspace Issue belongs to the Workspace team label Mar 28, 2022
@kylos101 kylos101 changed the title Use lazy consensus for some Team Workspace Components Improve review process for Team Workspace API Components Mar 28, 2022
@aledbf
Copy link
Member

aledbf commented Mar 28, 2022

Leave @aledbf as approver for the three components, but, replace approval from @csweichel with :

This still creates a bottleneck and pressure for one person :(

@kylos101
Copy link
Contributor Author

@aledbf touche. 🙏 I'll add to our call tomorrow to see what folks think about lazy consensus. Seems like the right approach, thank you for suggesting.

@utam0k
Copy link
Contributor

utam0k commented Mar 29, 2022

I may be overthinking this, but wouldn't we need three people to take into account those on vacation?
With two people, if one person is on vacation and the other one created the PR for that API himself, can't anyone review it until the other one comes back from vacation?

@kylos101 kylos101 moved this to In Progress in 🌌 Workspace Team Apr 4, 2022
@kylos101 kylos101 self-assigned this Apr 4, 2022
Repository owner moved this from In Progress to Done in 🌌 Workspace Team Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: workspace Issue belongs to the Workspace team
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants