You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe
A few folders for Workspace components require approval from explicit individuals. [1][2][3]
This can create bottlenecks for the team. As an experiment, we'd like to try using lazy consensus.
Describe the behaviour you'd like
With great power comes great responsibility. 🕷️ 👨
For the Team Workspace components mentioned above (APIs):
Replace @csweichel and @aledbf for 3 workspace APIs with @gitpod-io/engineering-workspace .
When teammates add approval for a PR containing API changes, the approval message must contain two things:
*. /LGTM
*. /hold for 28 hours as lazy consensus <-- to allow time for the team to consider the PR as a whole.
Describe alternatives you've considered
Leave @aledbf as approver for the three components, but, replace approval from @csweichel with :
I may be overthinking this, but wouldn't we need three people to take into account those on vacation?
With two people, if one person is on vacation and the other one created the PR for that API himself, can't anyone review it until the other one comes back from vacation?
Is your feature request related to a problem? Please describe
A few folders for Workspace components require approval from explicit individuals. [1][2][3]
This can create bottlenecks for the team. As an experiment, we'd like to try using lazy consensus.
Describe the behaviour you'd like
With great power comes great responsibility. 🕷️ 👨
For the Team Workspace components mentioned above (APIs):
*.
/LGTM
*.
/hold for 28 hours as lazy consensus
<-- to allow time for the team to consider the PR as a whole.Describe alternatives you've considered
Leave @aledbf as approver for the three components, but, replace approval from @csweichel with :
ws-daemon-api
-> @Furistows-manager-api
-> @sagor999Additional context
Ref: Slack
The text was updated successfully, but these errors were encountered: