Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[bridge] Fix wrong mapping of WorkspaceStatus to prebuild when "snapshot" is missing" #10006

Merged
merged 1 commit into from
May 16, 2022
Merged

Revert "[bridge] Fix wrong mapping of WorkspaceStatus to prebuild when "snapshot" is missing" #10006

merged 1 commit into from
May 16, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented May 13, 2022 •
edited
Loading

Reverts #9924

  • /werft no-preview=true

@geropl geropl requested a review from a team May 13, 2022 13:44
@roboquat
Copy link
Contributor

@geropl: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 13, 2022
@geropl geropl mentioned this pull request May 13, 2022
Closed
2 tasks
@iQQBot
Copy link
Contributor

iQQBot commented May 13, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-revert-9924-gpl-9676-snapshots.1
(with .werft/ from main)

@geropl
Copy link
Member Author

geropl commented May 13, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-revert-9924-gpl-9676-snapshots.2
(with .werft/ from main)

@csweichel
Copy link
Contributor

What broke with the original change?

@geropl
Copy link
Member Author

geropl commented May 16, 2022 •
edited by werft-gitpod-dev-com bot
Loading

@csweichel no updates to prebuilds, at all. 😬

@roboquat roboquat merged commit 6c4213e into main May 16, 2022
@roboquat roboquat deleted the revert-9924-gpl/9676-snapshots branch May 16, 2022 07:46
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laushinka laushinka laushinka approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production size/XL team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@geropl @roboquat @iQQBot @csweichel @laushinka