Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] update git safe directory at init workspace phase #10012

Merged
merged 1 commit into from
May 13, 2022

Conversation

sagor999
Copy link
Contributor

@sagor999 sagor999 commented May 13, 2022

Description

Instead of adding safe.directory to git config at workspace shutdown, do that at init workspace instead.
why?
that way if some git operation was running and we initiate shutdown, we don't fail workspace due to failure to add safe.directory into global git config.

Related Issue(s)

Fixes #10011

How to test

Open workspace, do some edits and changes
Close workspace
In dashboard, you should still see any uncommitted git changes and workspace should shutdown properly without errors.

Release Notes

[ws-daemon] fix some workspaces fail to shutdown correctly if git operation was interrupted due to workspace termination

Documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some workspaces fail due to failure to add git safe.directory into global config
3 participants