Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] log when ready probe fails #10082

Merged
merged 1 commit into from
May 17, 2022
Merged

[ws-daemon] log when ready probe fails #10082

merged 1 commit into from
May 17, 2022

Conversation

sagor999
Copy link
Contributor

@sagor999 sagor999 commented May 17, 2022

Description

Make sure that we log when ready probe fails. Currently it is never reported anywhere.

Related Issue(s)

Will help debug #10081

How to test

Release Notes

[ws-daemon] add log entry when ready probe fails

Documentation

@roboquat roboquat added size/S and removed size/XS labels May 17, 2022
@sagor999 sagor999 changed the title wip [ws-daemon] log when ready probe fails May 17, 2022
@sagor999 sagor999 marked this pull request as ready for review May 17, 2022 22:16
@sagor999 sagor999 requested a review from a team May 17, 2022 22:16
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 17, 2022
components/ws-daemon/pkg/daemon/daemon.go Outdated Show resolved Hide resolved
components/ws-daemon/pkg/daemon/daemon.go Outdated Show resolved Hide resolved
components/ws-daemon/pkg/daemon/daemon.go Outdated Show resolved Hide resolved
@sagor999
Copy link
Contributor Author

@csweichel PTAL ❤️

@roboquat roboquat merged commit cb04a49 into main May 17, 2022
@roboquat roboquat deleted the pavel/10081 branch May 17, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants