Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prebuilds] Fix stopping and snapshot state #10101

Merged
merged 1 commit into from
May 18, 2022
Merged

[prebuilds] Fix stopping and snapshot state #10101

merged 1 commit into from
May 18, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented May 18, 2022 •
edited
Loading

Description

  1. Removes error when state is available and snapshot is available.
  2. Removes the assumption that a stopping phase without a snapshot is an error. This is most likely an intermediate state where it will turn into something else, therefore we do nothing here.

Co-authored with @AlexTugarev

Related Issue(s)

Fixes #10054

How to test

In the preview environment, add a project and run a prebuild.
Once Ready, it should not switch to Failed.

Release Notes

NONE

Documentation

@laushinka laushinka requested a review from a team May 18, 2022 12:46
@laushinka laushinka changed the title Fix to stopping and snapshot state [prebuilds] Fix to stopping and snapshot state May 18, 2022
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 18, 2022
@laushinka laushinka requested a review from AlexTugarev May 18, 2022 12:46
@laushinka laushinka changed the title [prebuilds] Fix to stopping and snapshot state [prebuilds] Fix stopping and snapshot state May 18, 2022
AlexTugarev
AlexTugarev approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roboquat roboquat merged commit 2bc93c2 into main May 18, 2022
@roboquat roboquat deleted the laushinka/prebuild-prebuilds-are-10054 branch May 18, 2022 12:59
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[prebuild] prebuilds are marked as error even though they are in ready state
3 participants
@laushinka @AlexTugarev @roboquat