Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[baseserver] Change default metrics port to 9502 to not clash with kube-rbac-proxy #10109

Merged
merged 1 commit into from
May 18, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented May 18, 2022

Normally, we expose kube-rbac-proxy for metrics on port 9500. With #10099 we removed listening on localhost to avoid a pitfall where listening on localhost would be inaccessible from outside the container.

In this PR, the default port is updated to not clash with 9500 which we commonly use for metrics through kube-rbac-proxy. Currently, only usage is by public-api-server (which crash-loops due to this) and content-service which doesn't have kube-rbac-proxy deployed so this change is safe.

Description

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

NONE

@easyCZ easyCZ requested review from a team May 18, 2022 19:35
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels May 18, 2022
@roboquat roboquat merged commit 0273683 into main May 18, 2022
@roboquat roboquat deleted the mp/baseserver-default-metrics-port branch May 18, 2022 22:37
@sagor999
Copy link
Contributor

when we switch to baseserver, does it mean we will need to update metrics port on deployment to match new port? 🤔

@easyCZ
Copy link
Member Author

easyCZ commented May 19, 2022

@sagor999 for public api, the installer already uses the the cost that's changed in this PR so there's no change needed. For scraping, we parametrize the proxy url for Kube-rbac-proxy so there no change is needed either. This should work without requiring additional changes

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels May 19, 2022
@aledbf
Copy link
Member

aledbf commented Jun 2, 2022

We need to rollback this change. The issue here is not the collision but the Prometheus listening should happen in localhost, that way the traffic can go from kube-rbac-proxy to the localhost port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants