[installer, ws-manager]: Use installation shortname in URL templates #10127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #9875, failing image builds currently fail to produce any useful output. A possible cause, as described in this comment, is that the format of the
ws-manager
WorkspaceURLTemplate
strings is wrong.When we deployed with the old helm chart, these values were set in the relevant configmap like this:
gitpod/chart/templates/ws-manager-configmap.yaml
Lines 74 to 75 in 2f988c9
ie, they included a suffix after the
ws
.This PR tailors the installer output to produce these URLs in the same way the old helm chart did. Installation short name suffixes like
eu-02
are set here:https://github.com/gitpod-io/ops/blob/main/deploy/production/meta-eu02/app/installer-config.yaml#L6
so the URLs will now look like
https://{{ .Prefix }}.ws-eu02.example.com
.Related Issue(s)
Fixes #9875
How to test
I've tested this change in staging by editing the
ws-manager
configmap in staging to contain the correct URLs, restartingws-manager
and running an image build. I was able to see image build logs as expected:Release Notes
Documentation
None