Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotfiles layout in user preferences #10136

Merged
merged 1 commit into from
May 20, 2022
Merged

Update dotfiles layout in user preferences #10136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions components/dashboard/src/settings/Preferences.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,24 +123,27 @@ export default function Preferences() {
</PillLabel>
</h3>
<p className="text-base text-gray-500 dark:text-gray-400">Customize workspaces using dotfiles.</p>
<div className="mt-4 max-w-md">
<div className="mt-4 max-w-xl">
<h4>Repository URL</h4>
<input
type="text"
value={dotfileRepo}
className="w-full"
placeholder="e.g. https://github.com/username/dotfiles"
onChange={(e) => setDotfileRepo(e.target.value)}
/>
<span className="flex">
<input
type="text"
value={dotfileRepo}
className="w-96 h-9"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: It's painful to see the custom height here, but does the job for now. ☺️

placeholder="e.g. https://github.com/username/dotfiles"
onChange={(e) => setDotfileRepo(e.target.value)}
/>
<button className="secondary ml-2" onClick={() => actuallySetDotfileRepo(dotfileRepo)}>
Copy link
Contributor Author

@gtsiolis gtsiolis May 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: Using the secondary class here, as this does not need to be a primary action across all preferences, see relevant comment in #7639 (comment).

Save Changes
</button>
</span>
<div className="mt-1">
<p className="text-gray-500 dark:text-gray-400">
Add a repository URL that includes dotfiles. Gitpod will clone and install your dotfiles for
every new workspace.
Add a repository URL that includes dotfiles. Gitpod will
<br />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: Another hack around the needs to resolve #7639, see relevant comment in #7639 (comment).

clone and install your dotfiles for every new workspace.
</p>
</div>
<div className="mt-4 max-w-md">
<button onClick={() => actuallySetDotfileRepo(dotfileRepo)}>Save Changes</button>
</div>
</div>
</PageWithSubMenu>
</div>
Expand Down