Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Cleanup unuse annotations and network policy #10149

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented May 20, 2022

Description

Clean up workspace unuse annotations and network policy
annotations: IDE ports don't have metrics at all, and that's not how we scrape metrics in a production environment

		"prometheus.io/scrape":                  "true",
		"prometheus.io/path":                    "/metrics",
		"prometheus.io/port":                    strconv.Itoa(int(startContext.IDEPort)),

For network policy:
This setting only works in the preview environment, in prod, our monitoring is in another workspace, so this has no effect
network policy part replaced by gitpod-io/observability#121

Related Issue(s)

Fixes #

How to test

Start workspace, everything should be work as usally

Release Notes

NONE

Documentation

  • /werft withObservabilityBranch=pd/ws-metrics

@iQQBot
Copy link
Contributor Author

iQQBot commented May 20, 2022

/werft run

👍 started the job as gitpod-build-pd-cleanup-ws.3
(with .werft/ from main)

@iQQBot iQQBot marked this pull request as ready for review May 20, 2022 13:21
@iQQBot iQQBot requested a review from a team May 20, 2022 13:21
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 20, 2022
Copy link
Contributor

@sagor999 sagor999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but to be extra safe, I am going to put a hold and wait until @aledbf can confirm it is good as well.

/hold

@sagor999 sagor999 requested a review from aledbf May 20, 2022 17:58
@loujaybee loujaybee requested a review from a team May 30, 2022 09:30
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iQQBot
Copy link
Contributor Author

iQQBot commented May 31, 2022

Hi @aledbf could you have a look please?

@iQQBot
Copy link
Contributor Author

iQQBot commented May 31, 2022

/unhold

@roboquat roboquat merged commit 406da1e into main May 31, 2022
@roboquat roboquat deleted the pd/cleanup-ws branch May 31, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XL team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants