-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace] Cleanup unuse annotations and network policy #10149
Conversation
/werft run 👍 started the job as gitpod-build-pd-cleanup-ws.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but to be extra safe, I am going to put a hold and wait until @aledbf can confirm it is good as well.
/hold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @aledbf could you have a look please? |
/unhold |
Description
Clean up workspace unuse annotations and network policy
annotations: IDE ports don't have metrics at all, and that's not how we scrape metrics in a production environment
For network policy:
This setting only works in the preview environment, in prod, our monitoring is in another workspace, so this has no effect
network policy part replaced by gitpod-io/observability#121
Related Issue(s)
Fixes #
How to test
Start workspace, everything should be work as usally
Release Notes
Documentation