Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gateway Plugin to work on JetBrains Gateway 2022.2 #10156

Merged
merged 1 commit into from
May 23, 2022
Merged

Update Gateway Plugin to work on JetBrains Gateway 2022.2 #10156

merged 1 commit into from
May 23, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented May 20, 2022 •
edited
Loading

Description

Update JetBrains Gateway Plugin to work on Gateway 2022.2

Related Issue(s)

None.

How to test

Release Notes

Add support for JetBrains Gateway 2022.2

Documentation

None.

@felladrin
Copy link
Contributor Author

felladrin commented May 20, 2022 •
edited
Loading

We need to wait for a fix in Gradle IntelliJ Plugin before continuing the development of this PR.

@felladrin felladrin force-pushed the vn/update-jetbrains-gateway-plugin-for-build-222 branch from f745880 to 2864738 Compare May 23, 2022 08:47
@felladrin felladrin changed the title Update JetBrains Gateway Plugin to work on Gateway 2022.2 Update Gateway Plugin to work on JetBrains Gateway 2022.2 May 23, 2022
@felladrin
Copy link
Contributor Author

JetBrains team fixed it on v1.6.0 of the Gradle Plugin.

gitpod/components/ide/jetbrains/gateway-plugin/build.gradle.kts

Line 17 in 2864738

id("org.jetbrains.intellij") version "1.6.0"

So the PR is now ready for review.

@felladrin felladrin marked this pull request as ready for review May 23, 2022 09:13
@felladrin felladrin requested a review from a team May 23, 2022 09:13
@felladrin felladrin self-assigned this May 23, 2022
mustard-mh
mustard-mh approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Both work fine with me if we define works find as connect success and code sync ok

image

image

@roboquat roboquat merged commit acc55c4 into main May 23, 2022
@roboquat roboquat deleted the vn/update-jetbrains-gateway-plugin-for-build-222 branch May 23, 2022 10:26
@mustard-mh
Copy link
Contributor

Maybe we can define works fine in PR description next time? cc @felladrin

@felladrin
Copy link
Contributor Author

felladrin commented May 23, 2022 •
edited
Loading

Maybe we can define works fine in PR description next time? cc @felladrin

Good point, @mustard-mh! I should definitely define the parameters for considering it working fine. I'll describe it better next time! Thanks for reviewing it!

@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustard-mh mustard-mh mustard-mh approved these changes

Assignees

@felladrin felladrin

Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/XS team: IDE
Projects
🚀 IDE Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felladrin @mustard-mh @roboquat