Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev] Rebuild dev image #10157

Merged
merged 2 commits into from
May 20, 2022
Merged

[dev] Rebuild dev image #10157

merged 2 commits into from
May 20, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented May 20, 2022 •
edited
Loading

Description

Rebuild the gitpod dev image (so that it includes gitpod-io/workspace-images#842).

Release Notes

NONE

@andrew-farries andrew-farries requested review from a team May 20, 2022 14:37
@github-actions
Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@github-actions github-actions bot added team: IDE team: devx team: workspace Issue belongs to the Workspace team labels May 20, 2022
@roboquat roboquat merged commit 3d79c1c into main May 20, 2022
@roboquat roboquat deleted the af/rebuild-dev-image branch May 20, 2022 17:07
@iQQBot iQQBot mentioned this pull request May 20, 2022
Merged
@iQQBot
Copy link
Contributor

iQQBot commented May 20, 2022 •
edited
Loading

build failed with this error, maybe relate go version... or something else

see detail https://werft.gitpod-dev.com/job/gitpod-build-main.3323

baseserver/server.go:161:2: S1000: should use a simple channel send/receive instead of `select` with a single case (gosimple)
	select {
	^

@roboquat roboquat added deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production labels May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagor999 sagor999 sagor999 approved these changes

@iQQBot iQQBot iQQBot approved these changes

@meysholdt meysholdt meysholdt approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note-none size/S team: devx team: IDE team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrew-farries @iQQBot @meysholdt @sagor999 @roboquat