[ws-manager] add tests for createPVCForWorkspacePod #10165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenting
reviewed
May 23, 2022
Comment on lines
+269
to
+271
| if req.Spec.Class == "" { | ||
| fmt.Println() | ||
| } |
There was a problem hiding this comment.
Any reason printing out this empty line?
There was a problem hiding this comment.
copy paste error from the function above. :(
jenting
reviewed
May 23, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for createPVCForWorkspacePod
Related Issue(s)
Fixes #10162
How to test
Run the test :)
Release Notes
Documentation