Allow configuration of s3 region for registry backend #10200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team: delivery
nandajavarma
force-pushed
the
nvn/fix-9800
branch
from
720d7c5 to
3238c89
Compare
github-actions
bot
added
team: IDE
team: workspace
|
Hi @nandajavarma thanks for the PR. I think unlike self hosted team everyone would not have enough knowledge to operate using kots. e.g. Workspace team heavily relies on preview env and workspace-preview cluster for testing. For PRs like these we (at least me) would rely heavily on the testing performed by the author. Adding a screenshot or a short loom video can help me review it faster. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option to configure the bucket region. Alongside it also ensures the secret is created even when the registry is set to
inClustersince s3 backend can be set forinClusterregistry.Related Issue(s)
Fixes #9800
How to test
Use
S3as theIn-cluster Storage providerin KOTS config UI. You will see the option to set theRegionfor S3Release Notes
Documentation