Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[usage] Initial installer configuration #10228

Merged
merged 1 commit into from
May 27, 2022
Merged

[usage] Initial installer configuration #10228

merged 1 commit into from
May 27, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented May 24, 2022 •
edited
Loading

Description

This PR adds configuration for the installer to deploy the usage component. The config is under the epxerimental category for now so not used in self-hosted yet.

Related Issue(s)

How to test

# get kube config from a manual run of werft (only config from main is run on previews)
VM_NAME="mp-usage-c6af44ed29c" ./dev/preview/install-k3s-kubeconfig.sh

$ kubectl get deployment
NAME                  READY   UP-TO-DATE   AVAILABLE   AGE
blobserve             1/1     1            1           12h
content-service       1/1     1            1           12h
dashboard             1/1     1            1           12h
grafana               1/1     1            1           12h
ide-proxy             1/1     1            1           12h
image-builder-mk3     1/1     1            1           12h
kube-state-metrics    1/1     1            1           12h
kubescape             1/1     1            1           12h
minio                 1/1     1            1           12h
otel-collector        1/1     1            1           12h
payment-endpoint      1/1     1            1           12h
prometheus-operator   1/1     1            1           12h
proxy                 1/1     1            1           12h
public-api-server     1/1     1            1           12h
pyrra-api             1/1     1            1           12h
pyrra-kubernetes      1/1     1            1           12h
server                1/1     1            1           12h
usage                 1/1     1            1           65m
ws-manager            1/1     1            1           12h
ws-manager-bridge     1/1     1            1           12h
ws-proxy              1/1     1            1           12h

Note usage deployment running

Release Notes

NONE

Documentation

NONE

@easyCZ easyCZ force-pushed the mp/usage-setup-component branch from 232652d to 159abfe Compare May 25, 2022 07:31
@easyCZ easyCZ force-pushed the mp/usage-controller-installer branch from ff7f466 to 9e2d022 Compare May 25, 2022 07:41
@roboquat roboquat added size/XL and removed size/L labels May 25, 2022
@easyCZ easyCZ changed the title [usage-controller] Initial installer configuration [usage] Initial installer configuration May 25, 2022
@roboquat roboquat added size/L and removed size/XL labels May 25, 2022
@easyCZ easyCZ force-pushed the mp/usage-setup-component branch from 159abfe to ba3edac Compare May 25, 2022 08:20
@easyCZ easyCZ force-pushed the mp/usage-controller-installer branch 2 times, most recently from 4dd55e6 to 4f9b870 Compare May 25, 2022 08:40
Base automatically changed from mp/usage-setup-component to main May 25, 2022 11:35
@roboquat roboquat added size/XXL and removed size/L labels May 25, 2022
@easyCZ easyCZ force-pushed the mp/usage-controller-installer branch from 4f9b870 to d296035 Compare May 25, 2022 11:37
@roboquat roboquat added size/L and removed size/XXL labels May 25, 2022
@easyCZ easyCZ force-pushed the mp/usage-controller-installer branch from d296035 to 99d7d46 Compare May 25, 2022 11:38
@easyCZ easyCZ marked this pull request as ready for review May 25, 2022 11:38
@easyCZ easyCZ requested review from a team May 25, 2022 11:38
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team labels May 25, 2022
@easyCZ
Copy link
Member Author

easyCZ commented May 25, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-mp-usage-controller-installer.12
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/usage-controller-installer branch from 99d7d46 to 6473363 Compare May 25, 2022 12:25
@roboquat roboquat added size/XL and removed size/L labels May 25, 2022
@easyCZ easyCZ mentioned this pull request May 25, 2022
Merged
andrew-farries
andrew-farries approved these changes May 26, 2022
View reviewed changes
install/installer/pkg/components/usage/deployment.go Outdated Show resolved Hide resolved
install/installer/pkg/components/usage/deployment.go
EnableServiceLinks: pointer.Bool(false),
DNSPolicy: "ClusterFirst",
RestartPolicy: "Always",
TerminationGracePeriodSeconds: pointer.Int64(30),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be specified? It's the default AFAIK.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll want to tweak it down the line so keeping it here to make adjusting easier.

install/installer/pkg/components/usage/objects.go
return nil, nil
}

log.Debug("Detected experimental.WebApp.Usage configuration", cfg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to leave this log line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the time being when it's experimental, I'm keen to leave it just to have the interpretation of the config in CI a bit more transparent.

@roboquat roboquat added size/L and removed size/XL labels May 27, 2022
@easyCZ easyCZ force-pushed the mp/usage-controller-installer branch from ed089cd to fbcfebd Compare May 27, 2022 05:52
@roboquat roboquat merged commit 9f3d741 into main May 27, 2022
@roboquat roboquat deleted the mp/usage-controller-installer branch May 27, 2022 06:01
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production labels May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusludmann corneliusludmann corneliusludmann approved these changes

@mustard-mh mustard-mh mustard-mh approved these changes

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production release-note-none size/L team: delivery Issue belongs to the self-hosted team team: IDE team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@easyCZ @andrew-farries @mustard-mh @corneliusludmann @roboquat