Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipefail to workspace integration test #10232

Merged
merged 1 commit into from
May 25, 2022
Merged

Conversation

jenting
Copy link
Contributor

@jenting jenting commented May 25, 2022

Description

Add pipefail to workspace integration test to catch the errors during preparing the preview environment.
Also, disable the error when running the integration test to avoid the go test exit immediately once an error occurs when performing the test.

An example slack notification when prepares the preview environment error occurs.
image

Related Issue(s)

Fixes #

How to test

werft run github -j .werft/workspace-run-integration-tests.yaml

Release Notes

None

Documentation

N/A

@jenting jenting changed the title Debug integration test Add pipefail to workspace integration test May 25, 2022
@jenting jenting marked this pull request as ready for review May 25, 2022 03:53
@jenting jenting requested a review from a team May 25, 2022 03:53
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 25, 2022
@jenting jenting marked this pull request as draft May 25, 2022 04:34
@jenting jenting force-pushed the jenting/debug-inte-test branch from d2dbc02 to d354b86 Compare May 25, 2022 05:53
@roboquat roboquat added size/M and removed size/XS labels May 25, 2022
@jenting jenting force-pushed the jenting/debug-inte-test branch from d354b86 to 1959187 Compare May 25, 2022 06:47
Add pipefail to integration test when preparing the preview environment.
And add slack notifcation when preparing the preview environment failure.

Also, disable the error and exit immediately during `go test` to prevent
the integration test job exit immediately if the `go test` failure.

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting force-pushed the jenting/debug-inte-test branch from 1959187 to 29db7b7 Compare May 25, 2022 07:00
@jenting jenting marked this pull request as ready for review May 25, 2022 07:22
Copy link
Contributor

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@roboquat roboquat merged commit 9aa403f into main May 25, 2022
@roboquat roboquat deleted the jenting/debug-inte-test branch May 25, 2022 07:39
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants