Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix port name and desc missed for ranges ports #10250

Merged
merged 1 commit into from
May 25, 2022
Merged

Fix port name and desc missed for ranges ports #10250

merged 1 commit into from
May 25, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented May 25, 2022

Description

Port name and description sometimes missing. In nextState function we have many conditions that may cause this problem

This PR intro a new function genManagedPort to resolve gitpod.yml related configuration missing problem in all conditions above

Related Issue(s)

Fixes #

How to test

Note that port with range will work only when ports are opened. And refresh webpage should also work for them all

Port with ranges

  • Choose VSCode as IDE in preference
  • Start a workspace
  • Modify/Create a .gitpod.yml to add port with range code below
  - port: 1111-1234
    name: rangeName
    description: rangeDesc
    onOpen: open-preview
  • Exec curl lama.sh | MALA_PORT=1111 sh
  • See if port explorer display correct name and description and will open-preview after port opened

Init with .gitpod.yml

Watch .gitpod.yml

  • Change .gitpod.yml in your workspace, the tooltip in port explorer should reflect to yml file

Release Notes

Fix `ranges port` name and description not sent when ports state changed

Documentation

@mustard-mh mustard-mh requested a review from a team May 25, 2022 12:19
@iQQBot iQQBot self-assigned this May 25, 2022
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

Test good, Thanks 🙏

@roboquat roboquat merged commit 308601a into main May 25, 2022
@roboquat roboquat deleted the hw/port-name branch May 25, 2022 12:35
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/M team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants