Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kots] ensure secret creation for inCluster registry backend #10256

Merged
merged 1 commit into from
May 25, 2022

Conversation

nandajavarma
Copy link
Contributor

@nandajavarma nandajavarma commented May 25, 2022

Description

This fixes the currently existing bug, which prevents creation of secret for s3 when once chooses s3 for inCluster registry storage backend.

Related Issue(s)

Fixes #

How to test

Currently if you try to use s3 as the storage backend for inCluster registry, you will get an error when creating workspace.

Release Notes

None

Documentation

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@roboquat roboquat merged commit ab981e3 into main May 25, 2022
@roboquat roboquat deleted the nvn/fix-s3-secret branch May 25, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants