Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-proxy] SSH gateway support full channel type #10291

Merged
merged 1 commit into from
May 28, 2022
Merged

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented May 27, 2022

Description

Before, we introduce SSH Gateway, however, it only supports a few ssh channels, such as session, direct-tcpip
This prevents the use of other channels such as remote port forwarding
This PR add full channel support

Related Issue(s)

Fixes #10248
Fixes #6993

How to test

  1. start a workspace
  2. check everything is normal as before (vscode desktop, Jetbrains, copy/paste ssh command....)
  3. test remote port forward

example:
in local machine

ssh -vNR 8080:ipinfo.io:80 workspaceId#ownerToken@workspaceUrl

open workspace in vscode browser, run

lsof -i:8080 # you will see sshd is listen this port
curl https://localhost:8080 # you will see an IP address, this IP address is your local machine public IP address

image

Release Notes

SSH Gateway support remote port forward

Documentation

@iQQBot iQQBot requested a review from a team May 27, 2022 06:38
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 27, 2022
@akosyakov
Copy link
Member

@iQQBot Could we also collect analytics what kind of channels users are using? It can be another the PR against this one. Some new event like ssh_connection_channel? We also don't need to collect duplicates, i.e. register only once per a session. Feasible?

@akosyakov akosyakov requested a review from mustard-mh May 27, 2022 06:46
@iQQBot
Copy link
Contributor Author

iQQBot commented May 27, 2022

Could we also collect analytics what kind of channels users are using? It can be another the PR against this one. Some new event like ssh_connection_channel? We also don't need to collect duplicates, i.e. register only once per a session. Feasible?

Ok

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Jetbrains
image

For copy/paste ssh command
image

For vscode using local-app
image

For vscode using ssh gateway
image

also test remote port forward, it can connect to mysql through my local computer
image

works like a charm! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/L team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH Gateway doesn't support remote port-forward Allow forwarding of SSH & GPG agents in VSCode extension.
5 participants