Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ws-daemon] Use a metric for backup waiting time instead logs #10339

Merged
merged 1 commit into from
May 30, 2022
Merged

[ws-daemon] Use a metric for backup waiting time instead logs #10339

merged 1 commit into from
May 30, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 30, 2022 •
edited
Loading

How to test

  • Open multiple workspaces
  • Wait some minutes and close it all
  • Check the metric returns values
gitpod_ws_daemon_concurrent_backup_waiting_seconds_bucket{le="10"} 5
gitpod_ws_daemon_concurrent_backup_waiting_seconds_bucket{le="30"} 5
gitpod_ws_daemon_concurrent_backup_waiting_seconds_bucket{le="60"} 6
gitpod_ws_daemon_concurrent_backup_waiting_seconds_bucket{le="120"} 6
gitpod_ws_daemon_concurrent_backup_waiting_seconds_bucket{le="180"} 6
gitpod_ws_daemon_concurrent_backup_waiting_seconds_bucket{le="300"} 6
gitpod_ws_daemon_concurrent_backup_waiting_seconds_bucket{le="600"} 6
gitpod_ws_daemon_concurrent_backup_waiting_seconds_bucket{le="1800"} 6
gitpod_ws_daemon_concurrent_backup_waiting_seconds_bucket{le="+Inf"} 6

Release Notes

[ws-daemon] Use a metric for backup waiting time instead of logs

@aledbf aledbf marked this pull request as ready for review May 30, 2022 09:54
@aledbf aledbf requested a review from a team May 30, 2022 09:54
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 30, 2022
@roboquat roboquat merged commit afdf961 into main May 30, 2022
@roboquat roboquat deleted the aledbf/time branch May 30, 2022 10:42
@aledbf aledbf mentioned this pull request Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csweichel csweichel csweichel approved these changes

Assignees

@aledbf aledbf

Labels
release-note size/M team: workspace Issue belongs to the Workspace team
Projects
No open projects
🌌 Workspace Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @csweichel @roboquat