-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[db][payment][server] Implement TeamSubscription2.excludeFromMoreResources #10370
Conversation
public async up(queryRunner: QueryRunner): Promise<void> { | ||
if (!(await columnExists(queryRunner, TABLE_NAME, COLUMN_NAME))) { | ||
await queryRunner.query( | ||
`ALTER TABLE ${TABLE_NAME} ADD COLUMN ${COLUMN_NAME} tinyint(4) NOT NULL DEFAULT '1', ALGORITHM=INPLACE, LOCK=NONE `, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@jankeromnes I started testing, but never saw any update Chargebee -> back into our system: I wanted to see an entry for that subscription in the table, to make sure writing/default values are working. |
@geropl Thanks for looking into this, and for setting up a Chargebee webhook! (Forgot to do that when requesting review.) However, I believe that, even though I've fixed the webhook URL, and now Team Plan creation seems to work fine: Could you please take another look? 🙏 |
FYI, the column seems to be there in the DB (scroll to right):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, and when configuring everything correctly, it works as expected! 🧘 🚀
Description
Align the new
TeamSubscription2
shape with legacyTeamSubscription
by adding an equivalentexcludeFromMoreResources
DB flag.Related Issue(s)
Fixes https://github.com/gitpod-io/ops/issues/2346
How to test
./dev/preview/install-k3s-kubeconfig.sh
followed bykubectl port-forward mysql-0 3306 &
andmysql -h 127.0.0.1 -pjBzVMe2w4Yi7GagadsyB gitpod
)d_b_team_subscription2
has aexcludeFromMoreResources
columnRelease Notes
Documentation