Preview Envs on Harvester: Delete when inactive #10379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
do-not-merge/work-in-progress
do-not-merge/release-note-label-needed
size/M
size/L
and removed
size/M
labels
vulkoingim
force-pushed
the
aa/del-harvester
branch
from
212010d to
4f148e8
Compare
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
vulkoingim
changed the title
vulkoingim
commented
May 31, 2022
Comment on lines
475
to
479
| Object.entries(result).forEach(([key]) => logLine+=` ${key}:${result[key]},`); | ||
| logLine = logLine.slice(0, -1); | ||
|
|
||
| werft.log(sliceID, `${previewEnvironment.name} (${previewEnvironment.namespace}) - is-active=${isActive} ${logLine}`) |
There was a problem hiding this comment.
Not a fan of logging here, but it does make things cleaner
vulkoingim
force-pushed
the
aa/del-harvester
branch
2 times, most recently
from
6327cb2 to
db7a143
Compare
vulkoingim
force-pushed
the
aa/del-harvester
branch
from
8dc2474 to
1d0d1d9
Compare
mads-hartmann
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
Thanks for working on this, and I agree that removing the double negative is a nice improvement. I have left a few suggestions for improvements, but they can be done in a follow up PR if you prefer (I have added the hold label, so you can just remove it if you want to merge this and open a new PR).
This does not solve all of #9891 yet though, as currently we'd still delete the preview environment if e.g. the branch was missing or stale (it was mentioned as a comment on the issue). For that you'd need to modify the logic for previewsToDelete
vulkoingim
force-pushed
the
aa/del-harvester
branch
3 times, most recently
from
213815b to
4c6227a
Compare
vulkoingim
force-pushed
the
aa/del-harvester
branch
from
4c6227a to
86864d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
is-inactive->is-active, as double negatives make for a confusing experience (CHECKING_FOR_NO_DB_ACTIVITY, isInactive = false = actually active env, etc)Related Issue(s)
Fixes #9891
How to test
Following is a
platform-delete-preview-environmentsjob (no preview environments were harmed, as all are returned as active on that run)https://werft.gitpod-dev.com/job/gitpod-custom-aa-del-harvester.28
Release Notes