Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beta label from dotfiles in settings #10398

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Jun 1, 2022

Description

This will remove the beta label from dotfiles in settings, matching the upcoming updates in https://github.com/gitpod-io/website/pull/2152.

Cc @loujaybee

Screenshots

BEFORE AFTER
Screenshot 2022-06-01 at 10 53 11 AM (2) Screenshot 2022-06-01 at 10 53 18 AM (2)

Release Notes

Remove beta label from dotfiles in settings

@gtsiolis gtsiolis requested a review from a team June 1, 2022 07:56
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 1, 2022
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adding hold in case anyone else wants to take a look but feel free to land at will.

/hold

@@ -118,9 +118,6 @@ export default function Preferences() {

<h3 className="mt-12">
Dotfiles{" "}
<PillLabel type="warn" className="font-semibold mt-2 ml-2 py-0.5 px-2 self-center">
Beta
</PillLabel>
</h3>
<p className="text-base text-gray-500 dark:text-gray-400">Customize workspaces using dotfiles.</p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: Maybe we could also link back to the dotfiles documentation since this is also a complex topic on how it works, etc.

Screenshot 2022-06-01 at 11 10 18 AM

@gtsiolis gtsiolis requested a review from loujaybee June 1, 2022 08:13
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jun 1, 2022

Thanks for taking a look, @easyCZ! 🙏

@loujaybee I'm adding you as a reviewer to sync the change with https://github.com/gitpod-io/website/pull/2152. Once ready, simply 🅰️ approve and 🅱️ remove the do-not-merge/hold label.

I've also added one non-blocking comment above, see #10398 (comment). 🏓

@loujaybee
Copy link
Member

loujaybee commented Jun 1, 2022

@gtsiolis, website PR merged, approved, removed label 🙏

Should be okay to have a little delay in updating the product, we can then announce / mention in the next changelog!

Thanks for following up with this! 🚀

@loujaybee
Copy link
Member

Seems the build was failing due to extra import

Creating an optimized production build...
Failed to compile.

/tmp/build/components-dashboard--app.b1e5cfdab477495a0a70b6d108e3b04051592823/src/settings/Preferences.tsx
TypeScript error in /tmp/build/components-dashboard--app.b1e5cfdab477495a0a70b6d108e3b04051592823/src/settings/Preferences.tsx(9,1):
'PillLabel' is declared but its value is never read.  TS6133

     7 | import { useContext, useState } from "react";
     8 | import { PageWithSubMenu } from "../components/PageWithSubMenu";
  >  9 | import PillLabel from "../components/PillLabel";
       | ^
    10 | import SelectableCardSolid from "../components/SelectableCardSolid";
    11 | import { getGitpodService } from "../service/service";
    12 | import { ThemeContext } from "../theme-context";

Pushed commit to fix: 2d75a0c

@roboquat roboquat merged commit 1f8851d into main Jun 1, 2022
@roboquat roboquat deleted the gt/remote-beta-label branch June 1, 2022 17:58
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants