-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove beta label from dotfiles in settings #10398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Adding hold in case anyone else wants to take a look but feel free to land at will.
/hold
@@ -118,9 +118,6 @@ export default function Preferences() { | |||
|
|||
<h3 className="mt-12"> | |||
Dotfiles{" "} | |||
<PillLabel type="warn" className="font-semibold mt-2 ml-2 py-0.5 px-2 self-center"> | |||
Beta | |||
</PillLabel> | |||
</h3> | |||
<p className="text-base text-gray-500 dark:text-gray-400">Customize workspaces using dotfiles.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: Maybe we could also link back to the dotfiles documentation since this is also a complex topic on how it works, etc.
Thanks for taking a look, @easyCZ! 🙏 @loujaybee I'm adding you as a reviewer to sync the change with https://github.com/gitpod-io/website/pull/2152. Once ready, simply I've also added one non-blocking comment above, see #10398 (comment). 🏓 |
@gtsiolis, website PR merged, approved, removed label 🙏 Should be okay to have a little delay in updating the product, we can then announce / mention in the next changelog! Thanks for following up with this! 🚀 |
Seems the build was failing due to extra import
Pushed commit to fix: 2d75a0c |
Description
This will remove the beta label from dotfiles in settings, matching the upcoming updates in https://github.com/gitpod-io/website/pull/2152.
Cc @loujaybee
Screenshots
Release Notes