[ws-manager] show why pod entered completed state #10414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagor999
force-pushed
the
pavel/fix-completed-pod
branch
from
e993010 to
bc15994
Compare
csweichel
reviewed
Jun 2, 2022
|
Other than the nit, LGTM. /hold |
csweichel
approved these changes
Jun 2, 2022
Co-authored-by: Christian Weichel <chris@gitpod.io>
|
/unhold |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whenever workspace fails due to pod entered completed state, show an error message, so that it is easier for user to understand what went wrong.
Example:
Related Issue(s)
Fixes #
How to test
Try to open this workspace:
https://github.com/atduarte/test-new
You should see a clear error why it failed.
Here is a PR that also improved that specific error to be more clear: #10413
Release Notes
Documentation