Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bridge] Cleanup dead "probe" code (1/3) #10421

Merged
merged 1 commit into from
Jun 2, 2022
Merged

[bridge] Cleanup dead "probe" code (1/3) #10421

merged 1 commit into from
Jun 2, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Jun 2, 2022 •
edited
Loading

Description

This PR cleans up dead code (1/3 in the chain)

Related Issue(s)

Context: #9395

How to test

  • start a workspace on this branch
  • start a workspace in the preview env
  • check the logs kubectl logs ws-manager-bridge- ws-manager-bridge
  • note how:
    • everything is working as expected
    • bridge logs show no errors

Release Notes

NONE

Documentation

@geropl geropl force-pushed the gpl/9395-stuck-prebuilds branch from d9dea34 to 8625b65 Compare June 2, 2022 08:34
@roboquat roboquat added size/M and removed size/L labels Jun 2, 2022
@geropl geropl changed the title Gpl/9395 stuck prebuilds [bridge] Cleanup dead "probe" code Jun 2, 2022
@geropl geropl marked this pull request as ready for review June 2, 2022 08:37
@geropl geropl requested a review from a team June 2, 2022 08:37
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 2, 2022
@geropl geropl changed the title [bridge] Cleanup dead "probe" code [bridge] Cleanup dead "probe" code (1/3) Jun 2, 2022
@roboquat roboquat merged commit 69a0935 into main Jun 2, 2022
@roboquat roboquat deleted the gpl/9395-stuck-prebuilds branch June 2, 2022 10:11
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geropl @AlexTugarev @roboquat