Configure grpc_server histogram metrics with proper buckets #10518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: webapp
easyCZ
approved these changes
Jun 8, 2022
vulkoingim
force-pushed
the
aa/grpc-hist-buckets
branch
from
897178c to
2444d3b
Compare
aledbf
approved these changes
Jun 8, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configure grpc_server histogram metrics with proper buckets - this would make the metrics more accurate, as currently anything that takes more than 10s (default top bucket) would be inaccurate.
For reference the default buckets (11 in total) are:
This would also have the side effect of increasing the cardinality slightly, by adding 2 more labels (13 total buckets) for every grpc handler metric.
Release Notes