-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add secret to preview environments #10552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aaca71d
to
9261fe6
Compare
9261fe6
to
70a7880
Compare
70a7880
to
97c6a59
Compare
97c6a59
to
6248fa1
Compare
6248fa1
to
c64d341
Compare
This now comes into clusters via GCP Secret Manager and terraform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @andrew-farries! 🙏
I got a bit confused due to the two merged PRs, but I tested everything again and it still seems to work. 🎉 (Maybe this could have been a single PR, so that I could have reviewed/tested it only once? 🤔)
Yeah, sorry. I was hoping that this one would get merged quickly first. They ended up getting done in the wrong order 😄 |
Description
Following on from https://github.com/gitpod-io/ops/pull/2696 in which a secret was added to the Werft cluster for
core-dev
, this PR copies the secret from Werft into the k3s cluster for preview environments during deployment of each preview env.This process ensures that we get a secret containing Stripe API keys into preview environments, without the secret touching source control.
Related Issue(s)
Part of #9036
How to test
Manually trigger a werft job for this branch (Notion doc).
Within the cluster for the preview environment, verify that there is now a secret called
stripe-api-keys
:You may have to create
Release Notes
Documentation