Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gp-cli] add command to extend workspace timeout #10619

Merged
merged 1 commit into from
Jun 13, 2022
Merged

[gp-cli] add command to extend workspace timeout #10619

merged 1 commit into from
Jun 13, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Jun 13, 2022 •
edited
Loading

Description

Support configure workspace timeout with gp-cli

Related Issue(s)

Fixes #10525

How to test

unlimited plan

  • Open in gitpod.io with current PR
  • Exec cd components/gitpod-cli
  • Exec go run main.go timeout extend to see if current workspace timeout extended, how to check see image below

free plan

  • Open a workspace in preview env
  • Run gp timeout extend should reply error that plan of prev env not allow timeout extend

Release Notes

Add command `gp timeout extend` to extend timeout of current workspace

Documentation

https://github.com/gitpod-io/website/pull/2218

@mustard-mh mustard-mh marked this pull request as ready for review June 13, 2022 09:04
@mustard-mh mustard-mh requested a review from a team June 13, 2022 09:04
@mustard-mh mustard-mh marked this pull request as draft June 13, 2022 09:31
@roboquat roboquat added size/L and removed size/M labels Jun 13, 2022
@mustard-mh mustard-mh added size/M team: webapp Issue belongs to the WebApp team and removed size/L labels Jun 13, 2022
@mustard-mh mustard-mh marked this pull request as ready for review June 13, 2022 09:41
@mustard-mh mustard-mh requested a review from a team June 13, 2022 09:41
@iQQBot iQQBot self-assigned this Jun 13, 2022
geropl
geropl approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works as expected! 💯 👍

iQQBot
iQQBot approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm 🎉

/hold
If you want to change the license header

@roboquat roboquat added size/L and removed size/M labels Jun 13, 2022
@mustard-mh
Copy link
Contributor Author

mustard-mh commented Jun 13, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/unhold

Thank you folks, super fast 🚀🚀🚀

@mustard-mh mustard-mh removed the team: webapp Issue belongs to the WebApp team label Jun 13, 2022
@roboquat roboquat merged commit a732374 into main Jun 13, 2022
@roboquat roboquat deleted the hw/cli-timtout branch June 13, 2022 10:04
@loujaybee loujaybee requested a review from a team June 13, 2022 11:07
@akosyakov
Copy link
Member

@mustard-mh Don't forget to update docs.

@mustard-mh
Copy link
Contributor Author

@mustard-mh Don't forget to update docs.

Doc is ready here https://github.com/gitpod-io/website/pull/2218

@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jun 14, 2022
@andrew-farries andrew-farries mentioned this pull request Jun 21, 2022
Merged
3 tasks
@andreafalzetti andreafalzetti mentioned this pull request Jul 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

@iQQBot iQQBot iQQBot approved these changes

Assignees

@iQQBot iQQBot

Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/L team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend workspace timeout via gp CLI
5 participants
@mustard-mh @akosyakov @iQQBot @geropl @roboquat