Resolve prebuild updatables #10648
Merged
Resolve prebuild updatables #10648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
reviewed
Jun 14, 2022
geropl
reviewed
Jun 14, 2022
components/server/ee/src/prebuilds/prebuilt-status-maintainer.ts
Outdated
Show resolved
Hide resolved
Also, mark updatable as resolved if commit is gone.
AlexTugarev
force-pushed
the
at/prebuild-updateables
branch
from
918cc54 to
301aaab
Compare
|
@geropl, I've added a test for |
geropl
reviewed
Jun 15, 2022
| } | ||
| log.info("Could not create commit status.", { updatable, errorMessage: err?.message }); | ||
| // (AT) this might happen e.g. when a commit is removed from remote repository (force push). | ||
| // Note, we're ignoring those errors for tracing. |
geropl
reviewed
Jun 15, 2022
geropl
approved these changes
Jun 15, 2022
|
started the job as gitpod-build-at-prebuild-updateables.2 because the annotations in the pull request description changed |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures we resolve prebuild updatables even if there is an issue to create a commit status for.
Also to ensure we're not overloading this introduces proper limits to the periodic updater.