Add --schedule flag to usage run command
#10678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-farries
force-pushed
the
af/add-schedule-flag-to-usage
branch
from
0f56f84 to
6cd3157
Compare
jankeromnes
reviewed
Jun 16, 2022
components/usage/cmd/run.go
Outdated
| @@ -72,6 +73,7 @@ func run() *cobra.Command { | |||
| } | |||
|
|
|||
| cmd.Flags().BoolVar(&verbose, "verbose", false, "Toggle verbose logging (debug level)") | |||
| cmd.Flags().DurationVar(&schedule, "schedule", 1*time.Minute, "The schedule on which the reconciler should run") | |||
There was a problem hiding this comment.
Side-note: Maybe also increase the default reconciliation loop period to 30min or 1h? (I'm a little worried about high-frequency logging noise)
There was a problem hiding this comment.
Rebased to change the default frequency to 1 hour.
|
@andrew-farries The I wonder if we should do an extra step so that the Stripe secret also gets mounted as an |
To allow overriding the default scheduler when testing the reconciler locally. Change default to 1 hour.
andrew-farries
force-pushed
the
af/add-schedule-flag-to-usage
branch
from
6cd3157 to
4a15532
Compare
|
The stripe secret is already mounted into the usage component (#10631) The problem is that this PR doesn't set |
jankeromnes
approved these changes
Jun 16, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
--scheduleflag to theusage runcommand to allow setting the schedule on which the reconciler runs.The main motivation here is to make local development easier (don't have to wait 1 min after invoking the command to get a reconciliation run), but we'll probably want to set this in-cluster via a configmap later on.
Related Issue(s)
Part of #9036
How to test
DB_HOST=localhost DB_USERNAME=gitpod DB_PASSWORD=foo DB_PORT=3306 go run . run --api-key-file ./apikeys --schedule 5sReconciliation now runs after 5 seconds. Without the flag, reconciliation runs after 1m.
Release Notes