[kots]: allow multiple docker pull secrets #10685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team: delivery
mrsimonemms
force-pushed
the
sje/kots-multi-docker-secrets
branch
2 times, most recently
from
a989257 to
7d215d9
Compare
|
started the job as gitpod-build-sje-kots-multi-docker-secrets.3 because the annotations in the pull request description changed |
mrsimonemms
force-pushed
the
sje/kots-multi-docker-secrets
branch
from
7d215d9 to
03a8531
Compare
|
started the job as gitpod-build-sje-kots-multi-docker-secrets.5 because the annotations in the pull request description changed |
|
/werft run no-preview publish-to-kots 👍 started the job as gitpod-build-sje-kots-multi-docker-secrets.6 |
mrsimonemms
force-pushed
the
sje/kots-multi-docker-secrets
branch
from
03a8531 to
82b05bf
Compare
|
/werft run no-preview publish-to-kots 👍 started the job as gitpod-build-sje-kots-multi-docker-secrets.8 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For customers pulling from their own registry, the Docker secrets need to support multiple sources. This adds the multiple secrets and adds the registries to the
.experimental.webApp.server.defaultBaseImageRegistryWhitelistarray in the Gitpod Installer configRelated Issue(s)
Fixes #10298
How to test
Release Notes
Documentation