-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[supervisor] Make compatible with run-gp #10796
Conversation
/werft run 👍 started the job as gitpod-build-cw-run-gp-compat.4 |
started the job as gitpod-build-cw-run-gp-compat.5 because the annotations in the pull request description changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
- Maybe we should fix this
gp preview
command so that user can access URL in vscode built-in browser. - Cannot access task port 5000 (defined in .gitpod.yml) in preview env
- Log workspace location of
run-gp
is not correct (alwayshttp://localhost:8080/?folder=/workspace
, but we needhttp://localhost:8080/?folder=/workspace/<folder_name>
Are they run-gp
repo part's issue? Feel free to unhold
/hold
Those are run-gp issues indeed. I'll file them in the repo. /hold cancel |
filed gitpod-io/run-gp#13 and gitpod-io/run-gp#14 |
Description
Makes supervisor compatible with run-gp and cleans up some code.
How to test
In Gitpod no behaviour should change.
To test this with run-gp:
./hack/update-images.sh cw-run-gp-compat.3
./hack/update-assets.sh
go run main.go
Release Notes
Werft options: