Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisor] Make compatible with run-gp #10796

Merged
merged 1 commit into from
Jun 21, 2022
Merged

[supervisor] Make compatible with run-gp #10796

merged 1 commit into from
Jun 21, 2022

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Jun 21, 2022

Description

Makes supervisor compatible with run-gp and cleans up some code.

How to test

In Gitpod no behaviour should change.

To test this with run-gp:

  1. open a workspace on https://github.com/gitpod-io/run-gp
  2. run ./hack/update-images.sh cw-run-gp-compat.3
  3. run ./hack/update-assets.sh
  4. run go run main.go

Release Notes

NONE

Werft options:

  • /werft with-preview

@mustard-mh
Copy link
Contributor

mustard-mh commented Jun 21, 2022

/werft run

👍 started the job as gitpod-build-cw-run-gp-compat.4
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-cw-run-gp-compat.5 because the annotations in the pull request description changed
(with .werft/ from main)

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

  • Maybe we should fix this gp preview command so that user can access URL in vscode built-in browser.
  • Cannot access task port 5000 (defined in .gitpod.yml) in preview env
  • Log workspace location of run-gp is not correct (always http://localhost:8080/?folder=/workspace, but we need http://localhost:8080/?folder=/workspace/<folder_name>

Are they run-gp repo part's issue? Feel free to unhold

/hold

image

@csweichel
Copy link
Contributor Author

  • Maybe we should fix this gp preview command so that user can access URL in vscode built-in browser.
  • Cannot access task port 5000 (defined in .gitpod.yml) in preview env
  • Log workspace location of run-gp is not correct (always http://localhost:8080/?folder=/workspace, but we need http://localhost:8080/?folder=/workspace/<folder_name>

Are they run-gp repo part's issue? Feel free to unhold

Those are run-gp issues indeed. I'll file them in the repo.
Thank you for checking up on those.

/hold cancel

@roboquat roboquat merged commit ae7f3fd into main Jun 21, 2022
@roboquat roboquat deleted the cw/run-gp-compat branch June 21, 2022 14:05
@csweichel
Copy link
Contributor Author

filed gitpod-io/run-gp#13 and gitpod-io/run-gp#14

@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/L team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants