Skip to content

feature(supervisor): installation of dotfiles via Makefile #10811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ghuntley
Copy link
Contributor

@ghuntley ghuntley commented Jun 22, 2022

Description

I and many folks use a Makefile as a standard interface to dotfiles. This pull-request adds support for Makefiles

How to test

  • Change was directly applied using GitHub editor and is pending test
  • Start instance, configure dotfiles repo with Makefile - does it work?

Release Notes

feature: installation of dotfiles via Makefile

Documentation

Will require https://www.gitpod.io/docs/config-dotfiles to be updated once this ships.

@ghuntley
Copy link
Contributor Author

ghuntley commented Jun 22, 2022

/werft run

👍 started the job as gitpod-build-gh-dotfiles-makefile.1
(with .werft/ from main)

@ghuntley
Copy link
Contributor Author

ghuntley commented Jul 1, 2022

/werft run

👍 started the job as gitpod-build-gh-dotfiles-makefile.2
(with .werft/ from main)

@ghuntley ghuntley changed the title [DRAFT] feature(supervisor): installation of dotfiles via Makefile feature(supervisor): installation of dotfiles via Makefile Jul 1, 2022
@akosyakov
Copy link
Member

@csweichel @iQQBot does it make sense? Could you review please?

@iQQBot
Copy link
Contributor

iQQBot commented Jul 6, 2022

Under normal circumstances, the makefile itself will not have execute permission, and instead of executing the makefile directly, we use the make command

@andreafalzetti
Copy link
Contributor

andreafalzetti commented Jul 22, 2022

@ghuntley did you run some tests on this?

I think what @iQQBot is saying makes sense, you would not run Makefile instead you run the make cmd.

Is that what you do for your dotfiles?

Shall we convert the PR to draft for now? It doesn't seem to be ready to be merged 🤔

@stale
Copy link

stale bot commented Aug 10, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Aug 10, 2022
@stale stale bot closed this Aug 16, 2022
@felladrin felladrin deleted the gh/dotfiles-makefile branch August 16, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants