[usage] Fix flaky test for ListWorkspacesByID #10818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
commented
Jun 22, 2022
andrew-farries
approved these changes
Jun 22, 2022
|
Well, this just failed on that exact issue so this is definitely not the fix.. :P |
|
/hold |
easyCZ
force-pushed
the
mp/usage-fix-flaky-workspace-list
branch
from
3e87b6c to
b3a11a9
Compare
|
Found the problem. We created the connection at the start of the test, but re-used it for sub-tests. This meant the hooks didn't run properly. |
|
/unhold |
|
What do you mean by hooks in this context? |
https://github.com/gitpod-io/gitpod/blob/main/components/usage/pkg/db/conn.go#L75 - the |
|
Hmm, main still fails on the 2^16 test. Trying to reproduce. https://werft.gitpod-dev.com/job/gitpod-build-main.3638 |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes (~15/100 from my repeated runs), the DB cleanup hook post tests would conflict with the data creation and would cause the tests to fail due to the exact missing IDs. Generating new random IDs hasn't failed in my test runs.
How to test
Unit tests
Release Notes
Documentation
NONE