Skip to content

[experiments] Configure ConfigCat SDK through installer #10819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Jun 22, 2022

Description

In #10807, we are adding support for configuring configcat through an ENV variable to target various ConfigCat environments.

The SDK Key is NOT A SECRET, it is a unique identifier of app just like Google Analytics has a unique identifier.

Related Issue(s)

How to test

Run installer with config:

experimental:
	webApp:
		configcatKey: "config-cat-key-here"

Observe it's in the resulting yaml

Release Notes

NONE

Documentation

NONE

@easyCZ easyCZ requested review from a team June 22, 2022 12:19
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team labels Jun 22, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Jun 24, 2022

@gitpod-io/engineering-self-hosted Would you be able to please help review this?

@roboquat roboquat merged commit 58a9ebb into main Jun 24, 2022
@roboquat roboquat deleted the mp/configcat-sdk-installer branch June 24, 2022 09:58
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note-none size/S team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants