Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 5 second delay before returning feature flag value #10897

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Disable 5 second delay before returning feature flag value #10897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions components/dashboard/src/experiments/configcat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export function newProductionConfigCatClient(): Client {
// clientKey is an identifier of our ConfigCat application. It is not a secret.
const clientKey = "WBLaCPtkjkqKHlHedziE9g/TwAe6YyftEGPnGxVRXd0Ig";
const client = configcat.createClient(clientKey, {
maxInitWaitTimeSeconds: 0,
logger: configcat.createConsoleLogger(2),
});

Expand All @@ -35,6 +36,7 @@ export function newNonProductionConfigCatClient(): Client {
// clientKey is an identifier of our ConfigCat application. It is not a secret.
const clientKey = "WBLaCPtkjkqKHlHedziE9g/LEAOCNkbuUKiqUZAcVg7dw";
const client = configcat.createClient(clientKey, {
maxInitWaitTimeSeconds: 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of the default wait time of 5 seconds? Any downsides to setting it to 0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also surprised 5 secs was the default value, but my guess is that it's to ensure it doesn't slow down load of other assets.

In some use-cases, they instantiate the client inside index.ts and use afterwards.

Copy link
Contributor Author

@jankeromnes jankeromnes Jun 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but agree with @easyCZ's theory. 👍

Unfortunately, there seems to be no documentation for this feature apart from the one-line description shown in my PR description (see also ConfigCat's source code)

Digging a bit into ConfigCat's history, it looks like this feature was already part of this initial commit, which unfortunately doesn't provide much context as to why this feature is useful. 🙈

pollIntervalSeconds: 60 * 3, // 3 minutes
logger: configcat.createConsoleLogger(3),
});
Expand Down
1 change: 1 addition & 0 deletions components/server/src/experiments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export function getExperimentsClient(): IConfigCatClient {
if (client === undefined) {
client = configcat.createClient("WBLaCPtkjkqKHlHedziE9g/LEAOCNkbuUKiqUZAcVg7dw", {
// <-- This is the actual SDK Key for your Test environment
maxInitWaitTimeSeconds: 0,
logger: logger,
});
}
Expand Down