-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[usage] Add usageAttributionID to WorkspaceInstance model (in go) #10927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fa4ad76
to
1320d58
Compare
c414011
to
34d0776
Compare
223c661
to
2a54e55
Compare
1320d58
to
898d9ed
Compare
2a54e55
to
b966efd
Compare
b966efd
to
d416916
Compare
Many thanks for this PR! In general, I'm very much in favor of multiple smaller PRs. However (and maybe this is just me adjusting to this new paradigm), I still struggle with reviewing code that isn't used in any meaningful way. Thus, I took a peek at your other PR: #10938 👀
|
Here, the constructor and the destructor are mostly for completness and symmetry. Agree that ideally the destructor wasn't used in this PR (and perhaps should've been used in tests) but it felt incomplete without it.
This would also suffer from the same problem as above. I'd be creating a constructor for |
d416916
to
c48fee9
Compare
I've pulled in the two methods and added some tests for using the Value to showcase it better. Hopefully this addresses the above comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, many thanks! 🚀
Description
Adds model definition to consume usage attribution id
Related Issue(s)
How to test
Unit tests
Release Notes
Werft options: