-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: promote proxy service type from experimental #11006
Conversation
/werft run no-preview publish-to-kots 👍 started the job as gitpod-build-sje-installer-clusterip.2 |
fad3569
to
b76f6e3
Compare
b76f6e3
to
54c56f6
Compare
54c56f6
to
030133d
Compare
84c0398
to
cfc9446
Compare
Based upon @geropl's feedback, this PR has introduced the ability to deprecate fields from the Installer config which prints a deprecation notice to stderr and have added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a comment regarding overwriting the experimental config with the new config together with the KOTS UI change. I think that could break the installation when users have a config patch that set the serviceProxy
in the experimental section because this will be overwritten by the new proxy config in any case (solely by updating Gitpod with KOTS). I think we need at least a warning, better a property way to handle this.
The remaining comments are my 2 cents only. Feel free to disagree and ignore.
cfc9446
to
0979ae1
Compare
Ok, I've updated this so it has @corneliusludmann's elegant proposal of dealing with the experimental values. I've also changed the KOTS config so that the I want to refactor how the KOTS config is generated with the config patch file. Deprecations will come in that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it. 🤩
Thanks for taking my suggestions into consideration. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice pattern, thank you @mrsimonemms !
Description
Deprecated the proxy's service type in
experimental
and promotes it to the primary configuration. Implements the configuration as per #10983.Includes the KOTS config section in a separate "Components" group - the reasoning behind this is that there may be additional component-specific configuration in the future. This should make it easier to manage/visualise. This is only displayed if the "enable additional options" is enabled.
Adds the ability to deprecate config parameters.
I've also renamed "additional options" to "advanced options"
Related Issue(s)
Fixes #11008
Fixes #11009
Fixes #11025
Fixes #11033
How to test
Release Notes
Documentation
Werft options: