[ws-proxy] not use target host when serve workspace port route #11072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run 👍 started the job as gitpod-build-pd-fix-error-host.1 |
jenting
approved these changes
Jul 1, 2022
|
Test passed in preview env as well as preview env. /unhold |
1 task
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[ws-proxy] not use target host when serve workspace port route
At this PR #10514
We use targetHost in order to allow
blobservebehindide-proxyto process requests properly, but this creates a problem that causes users to receive the wrong host when they usehttps://{port}-workspaceUrl, which isinternal-pod-ip: port, this PR fixes that bugRelated Issue(s)
Fixes #11070
How to test
curl lama.sh | shgp preview $(gp url 8080) --externalto open a browser, you can see the log ofHostheader, it should be workspace port urlRelease Notes
Documentation
Werft options: