[installer]: set a stable password for messagebus #11096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the password and the erlang cookie secret
|
/hold as would like @mads-hartmann to add his approval too |
mads-hartmann
approved these changes
Jul 4, 2022
|
/unhold |
corneliusludmann
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This sets both the
rabbitmq.auth.passwordvalue and themessagebus-erlang-cookiesecret with static values. This has the benefit of not reloading the message bus every time a redeployment happens - this makes deployments faster and existing workspaces don't lose connections.The initial ticket only mentions the cookie secret, but discovered that the password is hardcoded in the experimental section - this doesn't change the functionality of
experiments.common.staticMessagebusPasswordso the Ops repo will still work as expected.Related Issue(s)
Fixes #10459
How to test
Deploy the application
Release Notes
Documentation
Werft options: