Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kots]: add monitoring graphs #11099

Merged
merged 1 commit into from
Jul 13, 2022
Merged

[kots]: add monitoring graphs #11099

merged 1 commit into from
Jul 13, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Jul 3, 2022

Description

Adds default monitoring graphs to the KOTS Graphs section of the app config. This allows users to connect to their own Prometheus instance and for the Gitpod instance to give out simple graphs. The graphs are based upon the published graphs in our monitoring docs.

image

NB we have limited (documented) control over the Y axis, so we end up with negative time periods by default. My feeling is that this is a convenience inside the KOTS dashboard and that, ultimately, most people will use Grafana over this. However, this should remain as a convenience for those who want a limited monitoring solution over a full-blown Grafana instance.

How to test

Install a Prometheus instance to your cluster and set the

As a convenience, my monitoring repo is already set up - the URL is http://monitoring-prometheus-prometheus.gitpod.svc.cluster.local:9090

NAMESPACE=gitpod
GITPOD_NAMESPACE=gitpod

helm upgrade \
  --atomic \
  --cleanup-on-fail \
  --create-namespace \
  --install \
  --namespace="${NAMESPACE}" \
  --repo=https://helm.simonemms.com \
  --reset-values \
  --set gitpodNamespace="${GITPOD_NAMESPACE}" \
  --wait \
  monitoring \
  gitpod-monitoring

Release Notes

[kots]: add monitoring graphs

Documentation

Werft options:

  • /werft with-preview

@mrsimonemms
Copy link
Contributor Author

Awaiting response to question

@roboquat roboquat removed the size/M label Jul 11, 2022
@mrsimonemms mrsimonemms marked this pull request as ready for review July 11, 2022 12:59
@mrsimonemms mrsimonemms requested a review from a team July 11, 2022 12:59
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Jul 11, 2022
Copy link
Contributor

@nandajavarma nandajavarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 📈

@roboquat roboquat merged commit 6ee0912 into main Jul 13, 2022
@roboquat roboquat deleted the sje/kots-graphs branch July 13, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants