Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-proxy] Add X-Forwarded-Port header #11110

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Jul 4, 2022

Description

Add X-Forwarded-Port header, as it's required by some software, like FusionAuth.

Related Issue(s)

How to test

  • Open a workspace on the Preview Environment of this PR.
  • Run curl lama.sh | sh
  • Run gp preview $(gp url 8080) --external to open a browser.
  • Confirm you see, in the terminal logs of the request, the X-Forwarded-Port header. It should be the same port displayed at the end of X-Forwarded-Host header.
    image

Release Notes

Requests on ws-proxy now contain also the `X-Forwarded-Port` header.

Documentation

None.

Werft options:

  • /werft with-preview

It's required by some software, like [FusionAuth](https://fusionauth.io/).
@felladrin felladrin requested a review from a team July 4, 2022 10:17
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jul 4, 2022
@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Jul 4, 2022
@roboquat roboquat merged commit a5e828f into main Jul 4, 2022
@roboquat roboquat deleted the felladrin/add-x-forwarded-port-header-to-ws-proxy branch July 4, 2022 11:50
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jul 6, 2022
@ChakshuGautam
Copy link

Hey @felladrin is it okay if we remove port suffix in the host here?

@felladrin
Copy link
Contributor Author

Hey @felladrin is it okay if we remove port suffix in the host here?

I think that would be fine and seems correct to don't have a port there. Let me open a PR and start a discussion about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants