Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s dependencies to v0.24.3 #11177

Merged
merged 7 commits into from
Aug 23, 2022
Merged

Update k8s dependencies to v0.24.3 #11177

merged 7 commits into from
Aug 23, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 6, 2022

Description

  • Update k8s dependencies to v0.24.3
  • Remove empty status and resource definitions from manifests

Related Issue(s)

fixes #8529
fixes #11136

How to test

  • Check workspaces work as usual
  • Check the generated manifests do not contain empty status or resource definitions
docker run --entrypoint sh --rm \
  eu.gcr.io/gitpod-core-dev/build/installer:aledbf-k8s24.11 -c "cat /app/installer" >gitpod-installer

chmod +x gitpod-installer

cat <<EOF >values.yaml
apiVersion: v1
domain: fake.gitpod.io
EOF

./gitpod-installer render --use-experimental-config --config values.yaml > manifests.yaml

Release Notes

NONE

Werft options:

  • /werft with-preview

@aledbf
Copy link
Member Author

aledbf commented Jul 6, 2022

/werft run

👍 started the job as gitpod-build-aledbf-k8s24.1
(with .werft/ from main)

@aledbf aledbf changed the title Aledbf/k8s24 Update k8s dependencies to v0.24.2 Jul 6, 2022
@aledbf
Copy link
Member Author

aledbf commented Jul 6, 2022

/werft run with-preview

👍 started the job as gitpod-build-aledbf-k8s24.7
(with .werft/ from main)

@aledbf aledbf marked this pull request as ready for review July 6, 2022 13:59
@aledbf aledbf requested a review from a team July 6, 2022 13:59
@aledbf aledbf requested review from a team July 6, 2022 13:59
@aledbf aledbf requested a review from akosyakov as a code owner July 6, 2022 13:59
@aledbf aledbf requested a review from a team July 6, 2022 13:59
@aledbf aledbf requested a review from corneliusludmann as a code owner July 6, 2022 13:59
@github-actions github-actions bot added team: IDE team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Jul 6, 2022
@corneliusludmann
Copy link
Contributor

It seems like this pull request implements item (3) as described in #11136, right?

I actually miss the discussion on this issue why we have decided to implement that solution and not one of the other proposed ones? 🤔

@corneliusludmann
Copy link
Contributor

Would you mind also removing this:

# Workaround for #8532 and #8529
echo "Gitpod: Remove the StatefulSet status object for OpenVSX Proxy"
yq eval-all --inplace \
'del(select(.kind == "StatefulSet" and .metadata.name == "openvsx-proxy").status)' \
"${GITPOD_OBJECTS}/templates/gitpod.yaml"

@aledbf
Copy link
Member Author

aledbf commented Jul 6, 2022

It seems like this pull request implements item (3) as described in #11136, right?

Yes.

I actually miss the discussion on this issue why we have decided to implement that solution and not one of the other proposed ones? thinking

Sorry, I assumed the only "real" option is 3.

  1. Post-process with yq

Too complex to maintain

  1. Lock the versions to the Kubernetes versions we support

We already do that (to some extent), pinning the versions with leeway.

@aledbf
Copy link
Member Author

aledbf commented Jul 6, 2022

Would you mind also removing this:

# Workaround for #8532 and #8529
echo "Gitpod: Remove the StatefulSet status object for OpenVSX Proxy"
yq eval-all --inplace \
'del(select(.kind == "StatefulSet" and .metadata.name == "openvsx-proxy").status)' \
"${GITPOD_OBJECTS}/templates/gitpod.yaml"

done

@gitguardian
Copy link

gitguardian bot commented Aug 12, 2022

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@aledbf
Copy link
Member Author

aledbf commented Aug 12, 2022

/werft run with-preview

👍 started the job as gitpod-build-aledbf-k8s24.15
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Aug 12, 2022

/werft run with-preview with-clean-slate-deployment

👍 started the job as gitpod-build-aledbf-k8s24.16
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Aug 22, 2022

@csweichel @Furisto @akosyakov @geropl friendly ping :)

@aledbf
Copy link
Member Author

aledbf commented Aug 22, 2022

/werft run with-preview with-clean-slate-deployment

👍 started the job as gitpod-build-aledbf-k8s24.20
(with .werft/ from main)

@roboquat roboquat merged commit 438ffab into main Aug 23, 2022
@roboquat roboquat deleted the aledbf/k8s24 branch August 23, 2022 06:18
@AlexTugarev
Copy link
Member

@aledbf, it seems this PR breaks the installer's render test. I see changes to the golden files of the installer tests, and I'm missing test run in the most recent build job of this PR.

Which version of the test data is correct?

@AlexTugarev AlexTugarev restored the aledbf/k8s24 branch August 23, 2022 08:16
@AlexTugarev
Copy link
Member

AlexTugarev commented Aug 23, 2022

📦 cached install/installer:raw-app

The tests were definitely not executed. Seems like cache control (invalidation) is broken in this area.

@aledbf aledbf mentioned this pull request Aug 23, 2022
1 task
@aledbf
Copy link
Member Author

aledbf commented Aug 23, 2022

@AlexTugarev #12299

@aledbf aledbf deleted the aledbf/k8s24 branch August 23, 2022 14:36
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production labels Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note-none size/XXL team: delivery Issue belongs to the self-hosted team team: devx team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
10 participants