-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s dependencies to v0.24.3 #11177
Conversation
/werft run 👍 started the job as gitpod-build-aledbf-k8s24.1 |
/werft run with-preview 👍 started the job as gitpod-build-aledbf-k8s24.7 |
It seems like this pull request implements item (3) as described in #11136, right? I actually miss the discussion on this issue why we have decided to implement that solution and not one of the other proposed ones? 🤔 |
Would you mind also removing this: gitpod/install/kots/manifests/gitpod-installer-job.yaml Lines 314 to 318 in 1b1248d
|
Yes.
Sorry, I assumed the only "real" option is 3.
Too complex to maintain
We already do that (to some extent), pinning the versions with leeway. |
done |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
/werft run with-preview 👍 started the job as gitpod-build-aledbf-k8s24.15 |
/werft run with-preview with-clean-slate-deployment 👍 started the job as gitpod-build-aledbf-k8s24.16 |
@csweichel @Furisto @akosyakov @geropl friendly ping :) |
/werft run with-preview with-clean-slate-deployment 👍 started the job as gitpod-build-aledbf-k8s24.20 |
@aledbf, it seems this PR breaks the installer's render test. I see changes to the golden files of the installer tests, and I'm missing test run in the most recent build job of this PR. Which version of the test data is correct? |
The tests were definitely not executed. Seems like cache control (invalidation) is broken in this area. |
Description
status
andresource
definitions from manifestsRelated Issue(s)
fixes #8529
fixes #11136
How to test
status
orresource
definitionsRelease Notes
Werft options: