Dummy implementation of UsageService (2/5) #11290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
force-pushed
the
gpl/10325-useapi-2
branch
2 times, most recently
from
8feacb8 to
dfde0b6
Compare
geropl
force-pushed
the
gpl/10325-useapi-2
branch
2 times, most recently
from
4f0ea03 to
c9e8162
Compare
geropl
force-pushed
the
gpl/10325-useapi-2
branch
from
c9e8162 to
6e30b14
Compare
geropl
changed the title
geropl
changed the title
geropl
changed the title
geropl
changed the title
easyCZ
approved these changes
Jul 12, 2022
| "google.golang.org/protobuf/testing/protocmp" | ||
| ) | ||
|
|
||
| func TestUsageService_GetBilledUsage(t *testing.T) { |
Comment on lines
+19
to
+23
| func (us *UsageService) GetBilledUsage(ctx context.Context, in *v1.GetBilledUsageRequest) (*v1.GetBilledUsageResponse, error) { | ||
| // TODO(geropl) Dummy data for now | ||
| response := v1.GetBilledUsageResponse{} | ||
| return &response, nil | ||
| } |
There was a problem hiding this comment.
If you wanted a terser version, you could do
Suggested change
| func (us *UsageService) GetBilledUsage(ctx context.Context, in *v1.GetBilledUsageRequest) (*v1.GetBilledUsageResponse, error) { | |
| // TODO(geropl) Dummy data for now | |
| response := v1.GetBilledUsageResponse{} | |
| return &response, nil | |
| } | |
| func (us *UsageService) GetBilledUsage(ctx context.Context, in *v1.GetBilledUsageRequest) (resp *v1.GetBilledUsageResponse, err error) { | |
| return resp, err | |
| } |
There was a problem hiding this comment.
I know, but I generally prefer the explicit syntax - and room for the comment. 😉
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dummy implementation of UsageService
Related Issue(s)
Context: #10325
How to test
(cd components/usage && go test -v ./...)Release Notes
Documentation
Werft options: