Skip to content

Extract gRPC ClientCallMetrics into protocol #11342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

Extract gRPC ClientCallMetrics into protocol #11342

merged 1 commit into from
Jul 20, 2022
+127 −141

Conversation

geropl
Copy link
Member

@geropl geropl commented Jul 13, 2022 •
edited
Loading

Description

During work on #10325 it became apparent we had duplicate/non-reusable code in various places.
This PR moves it into a central place (gitpod-protocol/src/util/grpc.ts) and makes use of it across the code base.

Related Issue(s)

Context: #10325

How to test

  • start any workspace in the preview env
  • see how it works as expected

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@geropl geropl changed the title [protocol, et al] Extract gRPC ClientCallMetrics into protocol Extract gRPC ClientCallMetrics into protocol Jul 13, 2022
@geropl geropl force-pushed the gpl/grpc-metrics branch 2 times, most recently from 94b2c6c to cbfdd78 Compare July 14, 2022 09:29
@geropl geropl marked this pull request as ready for review July 14, 2022 11:37
@geropl geropl requested a review from a team July 14, 2022 11:37
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 14, 2022
sagor999
sagor999 approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@sagor999 sagor999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code owner of only one file that had formatting fix only. so LGTM. 😄

@easyCZ
Copy link
Member

easyCZ commented Jul 19, 2022

@geropl Rebase please.

@geropl geropl force-pushed the gpl/grpc-metrics branch from cbfdd78 to 9374bae Compare July 19, 2022 10:30
@geropl
Copy link
Member Author

geropl commented Jul 19, 2022

@easyCZ building

csweichel
csweichel approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 2dc450d into main Jul 20, 2022
@roboquat roboquat deleted the gpl/grpc-metrics branch July 20, 2022 12:31
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf approved these changes

@easyCZ easyCZ easyCZ approved these changes

@csweichel csweichel csweichel approved these changes

@sagor999 sagor999 sagor999 approved these changes

@corneliusludmann corneliusludmann Awaiting requested review from corneliusludmann

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@geropl @easyCZ @aledbf @csweichel @sagor999 @roboquat