[local-preview] Remove cert-manager dependency

[Pothulapati]

Description

This PR removes the dependency of cert-manager and thus
reducing resource usage. This is replaced by the usage of
mkcert instead.

Each certificate is induvidually generated on those domains
and stored into specific files for k3s to apply them which
is then used by Gitpod.

Signed-off-by: Tarun Pothulapati tarun@gitpod.io

Related Issue(s)

Part of #11303

How to test

Release Notes

[local-preview] Remove `cert-manager` dependency

Documentation

Werft options:

• /werft with-preview

[Pothulapati]

Looks like this is enough, and we don't have to generate induvidual certs for each purpose.

[mrsimonemms]

I'm using the command docker run -p 443:443 --privileged --name gitpod --rm -it -v gitpod:/var/gitpod eu.gcr.io/gitpod-core-dev/build/local-preview:tar-lp-cert-manager.11 to test - I believe this is the correct command

[Pothulapati]

Correct @mrsimonemms

[mrsimonemms]

It's more a bit of branding than a problem, but is there any way we can make the certificate name be "Gitpod Local Preview" (or something similar)? (This in Firefox, but I guess it'll be the same everywhere)

[mrsimonemms]

/hold

[mrsimonemms]

Works beautifully. Only question is about the certificate name - if it's not possible or want to do later, feel free to remove the hold

Bug found

[Pothulapati]

It's a valid question, and looks like there is no direct mkcert way of setting the CA name as per FiloSottile/mkcert#260.

I just remembered I used https://github.com/smallstep/cli for similar tasks, and can try moving to that unless there is some concern using it. 🤔

cc: @lucasvaltl

[mrsimonemms]

Let's do as a future PR

I've removed my approval as cannot build image at moment. Investigating reasons

[Pothulapati]

So, I saw a similar image build error initially on this same change, but couldn't repro it. It could be a real issue. As this is just an improvement, I'd err on making sure if its a real problem or not before merging.

@adrienthebo Can you also PTAL once? 👀 😄

[adrienthebo]

I got a successful build when creating an environment against https://github.com/mrzarquon/gitpod-aws-toolkit (as that's where I'm doing most of my work right now). This should be good to go, but I'm running a test against gitpod-io/gitpod to see if I can reproduce the failure that you're seeing @mrsimonemms.

[adrienthebo]

LGTM!

[mrsimonemms]

I'm getting the same issue on both this PR and latest, so it's almost certainly not a problem introduced by this PR (I've also upgraded from Ubuntu 21.10 to 22.04, so it's probably my computer that's broken it)

Remove the hold at-will

[Pothulapati]

Removing the hold, but will continue testing and raise a separate issue if its something that we might have to fix.

/unhold