[local-preview] honour DO_NOT_TRACK env variable
#11430
Conversation
github-actions
bot
added
the
team: delivery
Pothulapati
added
do-not-merge/work-in-progress
and removed
size/XS
team: delivery
Pothulapati
force-pushed
the
tar/lp-do-not-track
branch
from
9450993 to
6f1e8dd
Compare
Pothulapati
force-pushed
the
tar/lp-do-not-track
branch
from
6f1e8dd to
4226c3b
Compare
| # honour DO_NOT_TRACK if set | ||
| if [ -z "${DO_NOT_TRACK}" ]; then | ||
| # manually tun the cronjob | ||
| kubectl create job gitpod-telemetry-init --from=cronjob/gitpod-telemetry |
There was a problem hiding this comment.
had to move this inside as run_telemetry also is useful for readyiness and showing that Gitpod is ready.
There was a problem hiding this comment.
Looks good. Just a thought, the DO_NOT_TRACK also works if you set DO_NOT_TRACK=0 - is it worth (perhaps in a future PR) setting the if statement to be "IF variable is set AND is equal to 1"?
/hold approving and you can decide how you want to resolve this (if indeed you do)
Pothulapati
force-pushed
the
tar/lp-do-not-track
branch
3 times, most recently
from
4221d2a to
b58f2db
Compare
|
👋 Question on this - when we set do-not-track, does all telemetry get turned off (incl. the regular nightly data package that gets sent also outside of local preview? Context: I'm thinking that it might be misleading if we don't turn that off as well, however I am wary of increasing the scope and complexity here. |
|
@lucasvaltl Yep, You are right. It would still run daily. My reason for knowingly skipping was that |
Pothulapati
force-pushed
the
tar/lp-do-not-track
branch
from
b58f2db to
2b90927
Compare
Currently, There is no way to disable telemetry for `local-preview` as we run the cronjob manaully during init, when Gitpod is ready. This fixes that by honouring [`DO_NOT_TRACK` envrionment variable](https://consoledonottrack.com/) , which when set prevent the script from triggering the cronjob manually. Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
Pothulapati
force-pushed
the
tar/lp-do-not-track
branch
from
2b90927 to
13ee67a
Compare
|
@lucasvaltl Updated the PR to also disable the daily telemetry job when |
|
/unhold |
Description
Currently, There is no way to disable telemetry for
local-previewas we run the cronjob manaully during init, when Gitpod is ready.
This fixes that by honouring
DO_NOT_TRACKenvrionment variable, which when set prevent the script from triggering the cronjob manually.
Signed-off-by: Tarun Pothulapati tarun@gitpod.io
Related Issue(s)
Fixes #11350
How to test
Add
-e DO_NOT_TRACK=1to the following docker run commandRelease Notes
Documentation
Werft options: