[ws-daemon] Add support for limiting number of processes in workspaces #11448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run with-preview 👍 started the job as gitpod-build-aledbf-proc.1 |
aledbf
changed the title
|
|
github-actions
bot
added
team: delivery
|
Shouldn't the limit update when I update the configmap? The value stays the same, even after Kubernetes has replaced the configmap in the container filesystem. |
|
@Furisto please check you are using the latest build. I commit the fix for that not long ago. (also, keep in mind the update could take > 30s) Edit: if this does not work, we need to check the code that detects the changes in ws-daemon - not related to this PR) |
|
With the new build, the update behaves as expected. |
Furisto
approved these changes
Jul 18, 2022
adrienthebo
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
LGTM, as @aledbf noted via Slack the preview environments don't yet use cgroups v2 so I can't directly verify but it looks sound to me.
roboquat
added
the
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow setting a limit to the number of processes inside a workspace. By default, we have none.
How to test
"procLimit": 512while true; do sleep 1 && date & donebash: fork: retry: Resource temporarily unavailable**
Release Notes
Werft options:
Note: testing this requires cgroups v2