Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-up: Enable rootless mode only in cgroup v1 #11491

Merged
merged 2 commits into from
Jul 26, 2022
Merged

docker-up: Enable rootless mode only in cgroup v1 #11491

merged 2 commits into from
Jul 26, 2022
+85 −74

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Jul 20, 2022 •
edited
Loading

Description

Enable rootless mode only in cgroup v1 because docker requires systemd when using rootless mode in cgroup v2.

Related Issue(s)

Fixes #9776

How to test

Check the following in cgroup v1/v2

  1. Open a workspace
  2. Run the below command on the workspace
$ docker run --rm --cpus 1 --memory 32m --name stress alexeiled/stress-ng --cpu=2
  1. Open another console, and run the below command and check if the limit is working
$ docker stats

Release Notes

Check the following in cgroup v1/v2
Eliminate dockerd rootless mode in cgroup v2

Documentation

Werft options:

  • /werft with-preview

@utam0k utam0k marked this pull request as ready for review July 20, 2022 08:58
@utam0k utam0k requested a review from a team July 20, 2022 08:58
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jul 20, 2022
@utam0k
Copy link
Contributor Author

utam0k commented Jul 20, 2022

/hold
until check the behavior in cgroup v2

utam0k added 2 commits July 26, 2022 10:10
@utam0k
docker-up: Update dependencies.
ea02dd6
@utam0k
docker-up: Enable rootless mode only in cgroup v1
5a4b6e0 
 Because docker requires systemd when using rootless mode in cgroup v2.
@utam0k
Copy link
Contributor Author

utam0k commented Jul 26, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment with-preview

👍 started the job as gitpod-build-to-docker-cgv2.9
(with .werft/ from main)

@utam0k
Copy link
Contributor Author

utam0k commented Jul 26, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-to-docker-cgv2.11
(with .werft/ from main)

@utam0k
Copy link
Contributor Author

utam0k commented Jul 26, 2022

/unhold

@roboquat roboquat merged commit 90b8032 into main Jul 26, 2022
@roboquat roboquat deleted the to/docker-cgv2 branch July 26, 2022 03:57
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/L team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support docker resource constraints
3 participants
@utam0k @jenting @roboquat