[usage] Request signed upload URL from content-service
#11493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold because it's based on #11474 |
|
started the job as gitpod-build-af-upload-usage-reports.18 because the annotations in the pull request description changed |
1 task
andrew-farries
force-pushed
the
af/upload-usage-reports
branch
3 times, most recently
from
3ef8e01 to
68c28fc
Compare
easyCZ
reviewed
Jul 22, 2022
easyCZ
reviewed
Jul 22, 2022
| @@ -20,6 +21,7 @@ import ( | |||
| func configmap(ctx *common.RenderContext) ([]runtime.Object, error) { | |||
| cfg := server.Config{ | |||
| ControllerSchedule: time.Hour.String(), | |||
| ContentServiceUrl: fmt.Sprintf("%s:%d", content_service.Component, content_service.RPCPort), | |||
There was a problem hiding this comment.
Thanks. aed2c3f
easyCZ
reviewed
Jul 22, 2022
| @@ -23,6 +23,7 @@ func TestConfigMap_ContainsSchedule(t *testing.T) { | |||
| require.JSONEq(t, | |||
| `{ | |||
| "controllerSchedule": "2m", | |||
| "contentServiceUrl": "content-service:8080", | |||
There was a problem hiding this comment.
Technically, this is not a URL, just an address
There was a problem hiding this comment.
Renamed (b50982f)
Base automatically changed from
af/store-usage-reports-with-content-service
to
main
July 22, 2022 11:16
roboquat
requested review from
csweichel,
geropl and
corneliusludmann
as code owners
|
/unhold |
andrew-farries
force-pushed
the
af/upload-usage-reports
branch
from
aed2c3f to
f149203
Compare
|
/werft run with-preview 👍 started the job as gitpod-build-af-upload-usage-reports.25 |
added 7 commits
July 23, 2022 19:32
Add a dependency on the `content-service-api` component. And run `leeway link`.
To handle connecting to the content-service gRPC API, retrieving signed upload URLs and uploading usage reports.
When the usage component starts up.
Populate the usage component's config file with the URL of the in-cluster content-service.
Show that the connection to the content service is up and running by requesting a signed upload URL and logging it.
andrew-farries
force-pushed
the
af/upload-usage-reports
branch
from
f149203 to
7d88600
Compare
Yes, that is surprising. The This should probably be more restrictive. |
easyCZ
approved these changes
Jul 25, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#11474 added a new
UsageReportServicetocontent-servicethat allowed S3 signed upload URLs to be retrieved for the purpose of uploading usage reports to cloud storage.This PR hooks up the
usagecomponent with thecontent-serviceso that it requests a signed upload URL fromcontent-serviceeach time it runs.Subsequent PRs will use this signed URL to actually upload usage reports to cloud storage.
Related Issue(s)
Part of #9036
Builds on #11474
How to test
Look at the logs for the
usagecomponent in the preview environment for this PR. When usage reconciliation runs it successfully requests a signed upload URL from thecontent-service:Release Notes
Documentation
Werft options: